ALSA: control: Make sure that id->index does not overflow
authorLars-Peter Clausen <lars@metafoo.de>
Wed, 18 Jun 2014 11:32:35 +0000 (13:32 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 11 Jul 2014 12:33:52 +0000 (13:33 +0100)
commitf7500568b7633324e7c4282bb8baa3ff3f17fd7a
tree9334f26a4f5d48269031a95c8b1a6a5d4d7ee70d
parente3ca27c942102af152aabb2d2a4ab5fa0abe7d95
ALSA: control: Make sure that id->index does not overflow

commit 883a1d49f0d77d30012f114b2e19fc141beb3e8e upstream.

The ALSA control code expects that the range of assigned indices to a control is
continuous and does not overflow. Currently there are no checks to enforce this.
If a control with a overflowing index range is created that control becomes
effectively inaccessible and unremovable since snd_ctl_find_id() will not be
able to find it. This patch adds a check that makes sure that controls with a
overflowing index range can not be created.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/core/control.c