eCryptfs: Remove buggy and unnecessary write in file name decode routine
authorMichael Halcrow <mhalcrow@google.com>
Wed, 26 Nov 2014 17:09:16 +0000 (09:09 -0800)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 20 Feb 2015 00:49:28 +0000 (00:49 +0000)
commitf2d130454e46c3989af1b4f882b6a666d24fa2e0
tree38e442edb9e6cc49bff8973595fa664501bf53e2
parent3ca74798ef821cc6558fc04f083edc98afa28b2a
eCryptfs: Remove buggy and unnecessary write in file name decode routine

commit 942080643bce061c3dd9d5718d3b745dcb39a8bc upstream.

Dmitry Chernenkov used KASAN to discover that eCryptfs writes past the
end of the allocated buffer during encrypted filename decoding. This
fix corrects the issue by getting rid of the unnecessary 0 write when
the current bit offset is 2.

Signed-off-by: Michael Halcrow <mhalcrow@google.com>
Reported-by: Dmitry Chernenkov <dmitryc@google.com>
Suggested-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/ecryptfs/crypto.c