libata: make ata_eh_qc_retry() bump scmd->allowed on bogus failures
authorGwendal Grignou <gwendal@google.com>
Fri, 7 Aug 2009 23:17:49 +0000 (16:17 -0700)
committerTejun Heo <tj@kernel.org>
Mon, 7 Oct 2013 19:18:25 +0000 (15:18 -0400)
commitf13e220161e738c2710b9904dcb3cf8bb0bcce61
tree5bc78b57686a1f700a94bfd5052d466acd37d727
parent0fed4c09dca6820adaee28e55cd4283e74d029cd
libata: make ata_eh_qc_retry() bump scmd->allowed on bogus failures

libata EH decrements scmd->retries when the command failed for reasons
unrelated to the command itself so that, for example, commands aborted
due to suspend / resume cycle don't get penalized; however,
decrementing scmd->retries isn't enough for ATA passthrough commands.

Without this fix, ATA passthrough commands are not resend to the
drive, and no error is signalled to the caller because:

- allowed retry count is 1
- ata_eh_qc_complete fill the sense data, so result is valid
- sense data is filled with untouched ATA registers.

Signed-off-by: Gwendal Grignou <gwendal@google.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org
drivers/ata/libata-eh.c