platform/x86: Kconfig: Replace select by depends on ACPI_WMI
authorSedat Dilek <sedat.dilek@gmail.com>
Wed, 8 Dec 2010 10:20:26 +0000 (11:20 +0100)
committerMatthew Garrett <mjg@redhat.com>
Fri, 7 Jan 2011 22:03:47 +0000 (17:03 -0500)
commite98062ed6dc46ed3270350e1040e19d44150d1d1
tree8ef0c444e4f6c65b40723fd4888822833a8cb121
parentc1f73658edc8ac6f624968b47a276361ce032ca9
platform/x86: Kconfig: Replace select by depends on ACPI_WMI

With 'make oldnoconfig' I see these warnings in linux-next (next-20101208):

drivers/platform/x86/Kconfig:422:error: recursive dependency detected!
drivers/platform/x86/Kconfig:422:       symbol EEEPC_WMI depends on ACPI_WMI
drivers/platform/x86/Kconfig:438:       symbol ACPI_WMI is selected by ACER_WMI
drivers/platform/x86/Kconfig:18:        symbol ACER_WMI depends on LEDS_CLASS
drivers/leds/Kconfig:10:        symbol LEDS_CLASS is selected by EEEPC_WMI

This patch replaces all "select on ACPI_WMI" by "depends on ACPI_WMI".

Quote from David Woodhouse:
"A better policy is: "NEVER USE SELECT"."

Reported-and-tested-by: Sedat Dilek <sedat.dilek@gmail.com>
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/Kconfig