staging: quatech_usb2: Potential lost wakeup scenario in TIOCMIWAIT
authorKautuk Consul <consul.kautuk@gmail.com>
Wed, 14 Sep 2011 03:26:21 +0000 (08:56 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 19 Sep 2011 17:46:18 +0000 (10:46 -0700)
commite8df1674d383d2ecc6efa8d7dba74c03aafdfdd7
tree029417765ee8f4d4e38b055f1744d1152417f8ae
parente228b7426e65df0f2e93c783c2c89baabe318b9b
staging: quatech_usb2: Potential lost wakeup scenario in TIOCMIWAIT

If the usermode app does an ioctl over this serial device  by
using TIOCMIWAIT, then the code will wait by setting the current
task state to TASK_INTERRUPTIBLE and then calling schedule().
This will be woken up by the qt2_process_modem_status on URB
completion when the port_extra->shadowMSR is set to the new
modem status.

However, this could result in a lost wakeup scenario due to a race
in the logic in the qt2_ioctl(TIOCMIWAIT) loop and the URB completion
for new modem status in qt2_process_modem_status.
Due to this, the usermode app's task will continue to sleep despite a
change in the modem status.

Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/quatech_usb2/quatech_usb2.c