net_sched: gact: Fix potential panic in tcf_gact().
authorHiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Fri, 3 Aug 2012 10:57:52 +0000 (19:57 +0900)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 19 Sep 2012 14:04:47 +0000 (15:04 +0100)
commite72c9bd7d87ae9780d8b87f9ab45041fc72f3f48
tree59f49fe18ea03c744d888f519eecadf57effaf63
parent9f871e883277cc22c6217db806376dce52401a31
net_sched: gact: Fix potential panic in tcf_gact().

[ Upstream commit 696ecdc10622d86541f2e35cc16e15b6b3b1b67e ]

gact_rand array is accessed by gact->tcfg_ptype whose value
is assumed to less than MAX_RAND, but any range checks are
not performed.

So add a check in tcf_gact_init(). And in tcf_gact(), we can
reduce a branch.

Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/sched/act_gact.c