rds: Make rds_sock_lock BH rather than IRQ safe.
authorDavid S. Miller <davem@davemloft.net>
Tue, 24 Jan 2012 22:03:44 +0000 (17:03 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Feb 2012 17:22:21 +0000 (09:22 -0800)
commite5efde92dd328a16d3bd4a9d6fbae2638e0c8646
tree73f6af508a63e6abc8ab8024c0209a03b1da8b65
parent4704f3edfdd3cc5918932577373c0dc165d52959
rds: Make rds_sock_lock BH rather than IRQ safe.

[ Upstream commit efc3dbc37412c027e363736b4f4c74ee5e8ecffc ]

rds_sock_info() triggers locking warnings because we try to perform a
local_bh_enable() (via sock_i_ino()) while hardware interrupts are
disabled (via taking rds_sock_lock).

There is no reason for rds_sock_lock to be a hardware IRQ disabling
lock, none of these access paths run in hardware interrupt context.

Therefore making it a BH disabling lock is safe and sufficient to
fix this bug.

Reported-by: Kumar Sanghvi <kumaras@chelsio.com>
Reported-by: Josh Boyer <jwboyer@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/rds/af_rds.c