ASoC: Intel: sst-acpi: Request firmware before SST platform driver probing
authorJarkko Nikula <jarkko.nikula@linux.intel.com>
Wed, 19 Feb 2014 08:30:38 +0000 (10:30 +0200)
committerMark Brown <broonie@linaro.org>
Wed, 19 Feb 2014 12:20:42 +0000 (21:20 +0900)
commite5161d7987f14338ad0a3cf376b9bb6838416183
tree072cc4c6481b44ff91ec919ea5bc5f183167bd4d
parent0c49a8c9f9fafdf4345259b9b50513905afcf860
ASoC: Intel: sst-acpi: Request firmware before SST platform driver probing

We originally thought to request SST audio DSP firmware during the SST
platform driver initialization. However plain request_firmware doesn't
work in driver probe paths if userspace is not ready to handle it. For
instance when drivers are built-in.

Implementing asynchronous firmware request in SST platform driver
initialization complicates code needlessly since it anyway will fail if
firmware is missing.

This is more simple to handle by requesting firmware asynchronously in
sst_acpi_probe() and register SST platform only after firmware is loaded.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/intel/sst-acpi.c
sound/soc/intel/sst-dsp.h