[SCSI] libfcoe: FIP should report link to libfc whether selected or not
authorJoe Eykholt <jeykholt@cisco.com>
Tue, 3 Nov 2009 19:48:27 +0000 (11:48 -0800)
committerJames Bottomley <James.Bottomley@suse.de>
Fri, 4 Dec 2009 18:01:13 +0000 (12:01 -0600)
commitdd42dac4ecd1799077c132aab35d3c36b26d4d8c
treed3ca67f50eccef31071bfe26e09bf97c686bc088
parent1f4aed818d26eb9ed54520fbeb85d5ee691baa94
[SCSI] libfcoe: FIP should report link to libfc whether selected or not

The fnic driver with FIP is reporting link up, even though it's down.

When the interface is shut down by the switch, we receive a clear
virtual link, and set the state reported to libfc as down, although
we still report it up.  Clearly wrong.  That causes the subsequent
link down event not to be reported, and /sys shows the host "Online".

Currently, in FIP mode, if an FCF times out, then link to libfc
is reported as down, to stop FLOGIs.  That interferes with the LLD
link down being reported.

Users really need to know the physical link information, to diagnose
cabling issues, so physical link status should be reported to libfc.

If the selected FCF needs to be reported, that should be done
separately, in a later patch.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/fcoe/libfcoe.c
include/scsi/libfcoe.h