iommu/msm: Fix error handling in msm_iommu_unmap()
authorJoerg Roedel <joerg.roedel@amd.com>
Thu, 26 Jan 2012 17:25:37 +0000 (18:25 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Feb 2012 19:17:01 +0000 (11:17 -0800)
commitd7cd8fc525c9322ceb1f1de26d7c6201aef9d842
tree68776c696d6382f07bdf5a4c6ee29e8ecc918054
parent61c39c6dcc3c7b3278c611a5bdcc135a1e4d825e
iommu/msm: Fix error handling in msm_iommu_unmap()

commit 05df1f3c2afaef5672627f2b7095f0d4c4dbc3a0 upstream.

Error handling in msm_iommu_unmap() is broken. On some error
conditions retval is set to a non-zero value which causes
the function to return 'len' at the end. This hides the
error from the user. Zero should be returned in those error
cases.

Cc: David Brown <davidb@codeaurora.org>
Cc: Stepan Moskovchenko <stepanm@codeaurora.org>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Acked-by: David Brown <davidb@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iommu/msm_iommu.c