ipv4: Don't do expensive useless work during inetdev destroy.
authorDavid S. Miller <davem@davemloft.net>
Mon, 14 Mar 2016 03:28:00 +0000 (23:28 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 30 Apr 2016 22:05:24 +0000 (00:05 +0200)
commitd72b450666d8d0ee1dc01911c4193bc27b71af3d
treefbf676f6c48916950faa77badf3fd3baf255af54
parent7ce55b83fbf2ff341aacfe825001d40e7bbccbe2
ipv4: Don't do expensive useless work during inetdev destroy.

commit fbd40ea0180a2d328c5adc61414dc8bab9335ce2 upstream.

When an inetdev is destroyed, every address assigned to the interface
is removed.  And in this scenerio we do two pointless things which can
be very expensive if the number of assigned interfaces is large:

1) Address promotion.  We are deleting all addresses, so there is no
   point in doing this.

2) A full nf conntrack table purge for every address.  We only need to
   do this once, as is already caught by the existing
   masq_dev_notifier so masq_inet_event() can skip this.

Reported-by: Solar Designer <solar@openwall.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Tested-by: Cyrill Gorcunov <gorcunov@openvz.org>
[bwh: Backported to 3.2: adjust filename, context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/ipv4/devinet.c
net/ipv4/fib_frontend.c
net/ipv4/netfilter/ipt_MASQUERADE.c