sched: Call tick_check_idle before __irq_enter
authorVenkatesh Pallipadi <venki@google.com>
Tue, 5 Oct 2010 00:03:23 +0000 (17:03 -0700)
committerIngo Molnar <mingo@elte.hu>
Mon, 18 Oct 2010 18:52:29 +0000 (20:52 +0200)
commitd267f87fb8179c6dba03d08b91952e81bc3723c7
treeddcd2f7429964367fcb4ab1dd230a970452d72da
parentaa483808516ca5cacfa0e5849691f64fec25828e
sched: Call tick_check_idle before __irq_enter

When CPU is idle and on first interrupt, irq_enter calls tick_check_idle()
to notify interruption from idle. But, there is a problem if this call
is done after __irq_enter, as all routines in __irq_enter may find
stale time due to yet to be done tick_check_idle.

Specifically, trace calls in __irq_enter when they use global clock and also
account_system_vtime change in this patch as it wants to use sched_clock_cpu()
to do proper irq timing.

But, tick_check_idle was moved after __irq_enter intentionally to
prevent problem of unneeded ksoftirqd wakeups by the commit ee5f80a:

    irq: call __irq_enter() before calling the tick_idle_check
    Impact: avoid spurious ksoftirqd wakeups

Moving tick_check_idle() before __irq_enter and wrapping it with
local_bh_enable/disable would solve both the problems.

Fixed-by: Yong Zhang <yong.zhang0@gmail.com>
Signed-off-by: Venkatesh Pallipadi <venki@google.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1286237003-12406-9-git-send-email-venki@google.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/sched.c
kernel/softirq.c