xfs: underflow bug in xfs_attrlist_by_handle()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 31 Oct 2013 18:00:10 +0000 (21:00 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 3 Jan 2014 04:33:35 +0000 (04:33 +0000)
commitcc5285f4c67a48e5775d633267f8e284626a990a
tree977dcf54c0a64f198baba06945601024983d4d7d
parent1016f060cfaf7c575fce3a92c987d21202da3261
xfs: underflow bug in xfs_attrlist_by_handle()

commit 31978b5cc66b8ba8a7e8eef60b12395d41b7b890 upstream.

If we allocate less than sizeof(struct attrlist) then we end up
corrupting memory or doing a ZERO_PTR_SIZE dereference.

This can only be triggered with CAP_SYS_ADMIN.

Reported-by: Nico Golde <nico@ngolde.de>
Reported-by: Fabian Yamaguchi <fabs@goesec.de>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
(cherry picked from commit 071c529eb672648ee8ca3f90944bcbcc730b4c06)
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/xfs/xfs_ioctl.c
fs/xfs/xfs_ioctl32.c