serial: drivers/serial/pmac_zilog.c: add missing unlock
authorJulia Lawall <julia@diku.dk>
Tue, 27 Apr 2010 21:05:20 +0000 (14:05 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 30 Apr 2010 16:20:34 +0000 (09:20 -0700)
commitc61fae964a5ee04c4e4a01caecaf778c2e26e589
tree428b757db833d033256f6e36d287d424336550fd
parentd9901660b53b92f0f3551c06588b8be38224b245
serial: drivers/serial/pmac_zilog.c: add missing unlock

In an error handling case the lock is not unlocked.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E1;
identifier f;
@@

f (...) { <+...
* spin_lock_irqsave (E1,...);
... when != E1
* return ...;
...+> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/serial/pmac_zilog.c