USB: xhci: don't start a halted endpoint before its new dequeue is set
authorMathias Nyman <mathias.nyman@linux.intel.com>
Tue, 18 Nov 2014 09:27:11 +0000 (11:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Nov 2014 15:33:15 +0000 (07:33 -0800)
commitc3492dbfa1050debf23a5b5cd2bc7514c5b37896
tree591ecc821a05d83238587ebd075610142bd416d6
parent8daee1352d51a32676b84bddcc0e3252d1caa833
USB: xhci: don't start a halted endpoint before its new dequeue is set

A halted endpoint ring must first be reset, then move the ring
dequeue pointer past the problematic TRB. If we start the ring too
early after reset, but before moving the dequeue pointer we
will end up executing the same problematic TRB again.

As we always issue a set transfer dequeue command after a reset
endpoint command we can skip starting endpoint rings at reset endpoint
command completion.

Without this fix we end up trying to handle the same faulty TD for
contol endpoints. causing timeout, and failing testusb ctrl_out write
tests.

Fixes: e9df17e (USB: xhci: Correct assumptions about number of rings per endpoint.)
Cc: <stable@vger.kernel.org> #v2.6.35
Tested-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-ring.c