get_net_ns_by_fd() oopses if proc_ns_fget() returns an error
authorAl Viro <viro@ZenIV.linux.org.uk>
Sun, 5 Jun 2011 00:37:35 +0000 (00:37 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 5 Jun 2011 21:11:09 +0000 (14:11 -0700)
commitc316e6a3084cef1a5857cd66bb5429c969f06c93
tree4e50df4d1c0d3df5db7fb8df51225adc950c417e
parent23c79d31a3dd2602ee1a5ff31303b2d7a2d3c159
get_net_ns_by_fd() oopses if proc_ns_fget() returns an error

BTW, looking through the code related to struct net lifetime rules has
caught something else:

struct net *get_net_ns_by_fd(int fd)
{
        ...
        file = proc_ns_fget(fd);
        if (!file)
                goto out;

        ei = PROC_I(file->f_dentry->d_inode);

while in proc_ns_fget() we have two return ERR_PTR(...) and not a single
path that would return NULL.  The other caller of proc_ns_fget() treats
ERR_PTR() correctly...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/net_namespace.c