drm/vmwgfx: fix integer overflow in vmw_surface_define_ioctl()
authorLi Qiang <liq3ea@gmail.com>
Tue, 28 Mar 2017 03:10:53 +0000 (20:10 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 5 Jun 2017 20:13:53 +0000 (21:13 +0100)
commitc2e7959f2ea446a417bf2cdb79792575852d17bb
tree2ffec1698bfdb25207e16436de9a7c31469d45b0
parent20996e6d81c907b10a5ab57c4172be97cb1a7de1
drm/vmwgfx: fix integer overflow in vmw_surface_define_ioctl()

commit e7e11f99564222d82f0ce84bd521e57d78a6b678 upstream.

In vmw_surface_define_ioctl(), the 'num_sizes' is the sum of the
'req->mip_levels' array. This array can be assigned any value from
the user space. As both the 'num_sizes' and the array is uint32_t,
it is easy to make 'num_sizes' overflow. The later 'mip_levels' is
used as the loop count. This can lead an oob write. Add the check of
'req->mip_levels' to avoid this.

Signed-off-by: Li Qiang <liqiang6-s@360.cn>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/gpu/drm/vmwgfx/vmwgfx_resource.c