pkt_sched: cls_u32: Fix locking in u32_change()
authorJarek Poplawski <jarkao2@gmail.com>
Tue, 20 Jan 2009 22:08:23 +0000 (14:08 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sun, 25 Jan 2009 00:36:19 +0000 (16:36 -0800)
commitc20cba0d08f3c6c10e0181077cca7f1833ffdb6b
tree657d8c37972be1c293bd0094f14d6668c93814ef
parent82e1a122a1b01eef12fccecde30b7e7fbf4ece0e
pkt_sched: cls_u32: Fix locking in u32_change()

[ Upstream commit: 6f57321422e0d359e83c978c2b03db77b967b7d5 ]

New nodes are inserted in u32_change() under rtnl_lock() with wmb(),
so without tcf_tree_lock() like in other classifiers (e.g. cls_fw).
This isn't enough without rmb() on the read side, but on the other
hand adding such barriers doesn't give any savings, so the lock is
added instead.

Reported-by: m0sia <m0sia@plotinka.ru>
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/sched/cls_u32.c