block: fix alignment_offset math that assumes io_min is a power-of-2
authorMike Snitzer <snitzer@redhat.com>
Wed, 8 Oct 2014 22:26:13 +0000 (18:26 -0400)
committerJens Axboe <axboe@fb.com>
Thu, 9 Oct 2014 15:41:40 +0000 (09:41 -0600)
commitb8839b8c55f3fdd60dc36abcda7e0266aff7985c
tree27372945d214df68a1f5e750399084642dbc04f9
parent9d8f0bcca6ffa024a822ce4ab1008ab663f06672
block: fix alignment_offset math that assumes io_min is a power-of-2

The math in both blk_stack_limits() and queue_limit_alignment_offset()
assume that a block device's io_min (aka minimum_io_size) is always a
power-of-2.  Fix the math such that it works for non-power-of-2 io_min.

This issue (of alignment_offset != 0) became apparent when testing
dm-thinp with a thinp blocksize that matches a RAID6 stripesize of
1280K.  Commit fdfb4c8c1 ("dm thin: set minimum_io_size to pool's data
block size") unlocked the potential for alignment_offset != 0 due to
the dm-thin-pool's io_min possibly being a non-power-of-2.

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
block/blk-settings.c
include/linux/blkdev.h