PCI: pciehp: Fix wrong workqueue cleanup
authorKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Mon, 7 Nov 2011 11:55:46 +0000 (20:55 +0900)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 6 Feb 2013 04:33:32 +0000 (04:33 +0000)
commitb4f439edeea055ea3681618e1c299ab3a3d32cdc
treefe5460a2b4f5391ef470f40ae97a349b7848c44b
parent3e4ba2bf729b851695f01b514e1605dc0cffd5c8
PCI: pciehp: Fix wrong workqueue cleanup

commit 027e8d52abdd44bc00e405af83cd2fbfb96c0824 upstream.

Fix improper workqueue cleanup.

In the current pciehp, pcied_cleanup() calls destroy_workqueue()
before calling pcie_port_service_unregister(). This causes kernel oops
because flush_workqueue() is called in the pcie_port_service_unregister()
code path after the workqueue was destroyed. So pcied_cleanup() must call
pcie_port_service_unregister() first before calling destroy_workqueue().

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/pci/hotplug/pciehp_core.c