cls_api.c: Fix dumping of non-existing actions' stats.
authorIgnacy Gawędzki <ignacy.gawedzki@green-communications.fr>
Tue, 3 Feb 2015 18:05:18 +0000 (19:05 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Feb 2015 04:26:12 +0000 (20:26 -0800)
commitb057df24a7536cce6c372efe9d0e3d1558afedf4
tree4c062e5a5eb0c470ff686b741d85814ba66a593a
parent3725a269815ba6dbb415feddc47da5af7d1fac58
cls_api.c: Fix dumping of non-existing actions' stats.

In tcf_exts_dump_stats(), ensure that exts->actions is not empty before
accessing the first element of that list and calling tcf_action_copy_stats()
on it.  This fixes some random segvs when adding filters of type "basic" with
no particular action.

This also fixes the dumping of those "no-action" filters, which more often
than not made calls to tcf_action_copy_stats() fail and consequently netlink
attributes added by the caller to be removed by a call to nla_nest_cancel().

Fixes: 33be62715991 ("net_sched: act: use standard struct list_head")
Signed-off-by: Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr>
Acked-by: Cong Wang <cwang@twopensource.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_api.c