ACPI / sysfs: fix error code in get_status()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 5 May 2016 13:23:04 +0000 (16:23 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 22 Aug 2016 21:37:09 +0000 (22:37 +0100)
commitae9dc44c3756db582c72e638c872391944b58968
treead87b8c8af21512dae982319bb5f25db8669d053
parentbdcc4ee48674325c8fe68939b8b2f2771ca6d519
ACPI / sysfs: fix error code in get_status()

commit f18ebc211e259d4f591e39e74b2aa2de226c9a1d upstream.

The problem with ornamental, do-nothing gotos is that they lead to
"forgot to set the error code" bugs.  We should be returning -EINVAL
here but we don't.  It leads to an uninitalized variable in
counter_show():

    drivers/acpi/sysfs.c:603 counter_show()
    error: uninitialized symbol 'status'.

Fixes: 1c8fce27e275 (ACPI: introduce drivers/acpi/sysfs.c)
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/acpi/sysfs.c