btrfs: ensure that file descriptor used with subvol ioctls is a dir
authorJeff Mahoney <jeffm@suse.com>
Wed, 21 Sep 2016 12:31:29 +0000 (08:31 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 20 Nov 2016 01:01:42 +0000 (01:01 +0000)
commitaa1e138422a6bd04a7b0cbd425919cbd834cd395
treee45fdd69c94c7a8eff23f96880e150acf5b2505d
parent25a0d70d6162a76eebfbff33acd5746d99c32c4e
btrfs: ensure that file descriptor used with subvol ioctls is a dir

commit 325c50e3cebb9208009083e841550f98a863bfa0 upstream.

If the subvol/snapshot create/destroy ioctls are passed a regular file
with execute permissions set, we'll eventually Oops while trying to do
inode->i_op->lookup via lookup_one_len.

This patch ensures that the file descriptor refers to a directory.

Fixes: cb8e70901d (Btrfs: Fix subvolume creation locking rules)
Fixes: 76dda93c6a (Btrfs: add snapshot/subvolume destroy ioctl)
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Chris Mason <clm@fb.com>
[bwh: Backported to 3.2:
 - Open-code file_inode()
 - Adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/btrfs/ioctl.c