mv643xx_eth: avoid dropping tx lock during transmit reclaim
authorLennert Buytenhek <buytenh@wantstofly.org>
Sat, 13 Sep 2008 02:16:15 +0000 (04:16 +0200)
committerLennert Buytenhek <buytenh@marvell.com>
Sun, 14 Sep 2008 12:09:06 +0000 (14:09 +0200)
commita418950c1378c4a3722baecdbe98df78ea23f231
tree6c92a9e59c85c82b306c55bdd0a5b7fc3ce89516
parent8fd89211bf8e8e60415c66e5546c1478f5e8bc2b
mv643xx_eth: avoid dropping tx lock during transmit reclaim

By moving DMA unmapping during transmit reclaim back under the netif
tx lock, we avoid the situation where we read the DMA address and buffer
length from the descriptor under the lock and then not do anything with
that data after dropping the lock on platforms where the DMA unmapping
routines are all NOPs (which is the case on all ARM platforms that
mv643xx_eth is used on at least).

This saves two uncached reads, which makes a small but measurable
performance difference in routing benchmarks.

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
drivers/net/mv643xx_eth.c