power_supply: ipaq_micro_battery: Check return values in probe
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Fri, 20 Feb 2015 13:32:24 +0000 (14:32 +0100)
committerSebastian Reichel <sre@kernel.org>
Wed, 25 Feb 2015 21:18:18 +0000 (22:18 +0100)
commita2c1d531854c4319610f1d83351213b47a633969
tree70d4f9b5bd25c39dd11ccb80af24b379baaa5a6c
parentf852ec461e24504690445e7d281cbe806df5ccef
power_supply: ipaq_micro_battery: Check return values in probe

The return values of create_singlethread_workqueue() and
power_supply_register() calls were not checked and even on error probe()
function returned 0.

1. If allocation of workqueue failed (returning NULL) then further
   accesses could lead to NULL pointer dereference. The
   queue_delayed_work() expects workqueue to be non-NULL.

2. If registration of power supply failed then during unbind the driver
   tried to unregister power supply which was not actually registered.
   This could lead to memory corruption because
   power_supply_unregister() unconditionally cleans up given power
   supply.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: 00a588f9d27f ("power: add driver for battery reading on iPaq h3xxx")
Cc: <stable@vger.kernel.org>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/power/ipaq_micro_battery.c