[SCSI] sd: Fix potential out-of-bounds access
authorAlan Stern <stern@rowland.harvard.edu>
Fri, 6 Sep 2013 15:49:51 +0000 (11:49 -0400)
committerJames Bottomley <JBottomley@Parallels.com>
Wed, 11 Sep 2013 16:44:00 +0000 (09:44 -0700)
commit984f1733fcee3fbc78d47e26c5096921c5d9946a
tree2f36698d0e3a90f653d5c6673c2144b3530cb1c6
parent76c4f79d909623ea144262626428a2dfb54b40e3
[SCSI] sd: Fix potential out-of-bounds access

This patch fixes an out-of-bounds error in sd_read_cache_type(), found
by Google's AddressSanitizer tool.  When the loop ends, we know that
"offset" lies beyond the end of the data in the buffer, so no Caching
mode page was found.  In theory it may be present, but the buffer size
is limited to 512 bytes.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
CC: <stable@vger.kernel.org>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/sd.c