powerpc: Convert cmp to cmpd in idle enter sequence
authorSegher Boessenkool <segher@kernel.crashing.org>
Thu, 6 Oct 2016 13:42:19 +0000 (13:42 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 23 Feb 2017 03:50:54 +0000 (03:50 +0000)
commit964da8f0dfc82fe88cad23ec86dadd0e07b13885
tree6ee8a45a5209dab0ba37f0747195b762b1e4533a
parentbde40aa4b0b7318fd6c76ea29fc918cbcee6747a
powerpc: Convert cmp to cmpd in idle enter sequence

commit 80f23935cadb1c654e81951f5a8b7ceae0acc1b4 upstream.

PowerPC's "cmp" instruction has four operands. Normally people write
"cmpw" or "cmpd" for the second cmp operand 0 or 1. But, frequently
people forget, and write "cmp" with just three operands.

With older binutils this is silently accepted as if this was "cmpw",
while often "cmpd" is wanted. With newer binutils GAS will complain
about this for 64-bit code. For 32-bit code it still silently assumes
"cmpw" is what is meant.

In this instance the code comes directly from ISA v2.07, including the
cmp, but cmpd is correct. Backport to stable so that new toolchains can
build old kernels.

Fixes: 948cf67c4726 ("powerpc: Add NAP mode support on Power7 in HV mode")
Reviewed-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
[bwh: Backported to 3.2: adjust filename, context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/powerpc/kernel/idle_power7.S