RS485: fix inconsistencies in the meaning of some variables
authorClaudio Scordino <claudio@evidence.eu.com>
Wed, 9 Nov 2011 14:51:49 +0000 (15:51 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 15 Nov 2011 20:13:44 +0000 (12:13 -0800)
commit93f3350c46fa5dfcc9650eb19b186e71ffc924c3
tree13b6f81f9fd85227283b38af6267d094e0038beb
parent90f04c2926cfb5bf74533b0a7766bc896f6a0c0e
RS485: fix inconsistencies in the meaning of some variables

The crisv10.c and the atmel_serial.c serial drivers intepret the fields of the
serial_rs485 structure in a different way.

In particular, crisv10.c uses SER_RS485_RTS_AFTER_SEND and
SER_RS485_RTS_ON_SEND for the voltage of the RTS pin; atmel_serial.c,
instead, uses these values to know if a delay must be set before and
after sending.  This patch makes the usage of these variables consistent
across all drivers and fixes the Documentation as well.

From now on, SER_RS485_RTS_AFTER_SEND and SER_RS485_RTS_ON_SEND will be
used to set the voltage of the RTS pin (as in the crisv10.c driver); the
delay will be understood by looking only at the value of
delay_rts_before_send and delay_rts_after_send.

Signed-off-by: Claudio Scordino <claudio@evidence.eu.com>
Signed-off-by: Darron Black <darron@griffin.net>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Documentation/serial/serial-rs485.txt
drivers/tty/serial/atmel_serial.c
drivers/tty/serial/crisv10.c
include/linux/serial.h