USB: serial: digi_acceleport: fix OOB data sanity check
authorJohan Hovold <johan@kernel.org>
Tue, 31 Jan 2017 16:17:27 +0000 (17:17 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 5 Jun 2017 20:13:46 +0000 (21:13 +0100)
commit90f4c688d372b04cf401906098fc03db0a567814
tree41ba40af887db5594c2845278fa125fafc78e3c8
parent6e6fb360d9b9741c1a063e6659760e4dc4c056be
USB: serial: digi_acceleport: fix OOB data sanity check

commit 2d380889215fe20b8523345649dee0579821800c upstream.

Make sure to check for short transfers to avoid underflow in a loop
condition when parsing the receive buffer.

Also fix an off-by-one error in the incomplete sanity check which could
lead to invalid data being parsed.

Fixes: 8c209e6782ca ("USB: make actual_length in struct urb field u32")
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/serial/digi_acceleport.c