USB: serial: omninet: fix reference leaks at open
authorJohan Hovold <johan@kernel.org>
Mon, 6 Mar 2017 16:36:38 +0000 (17:36 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 5 Jun 2017 20:13:56 +0000 (21:13 +0100)
commit8b236342396140be22ab9b486c412666f161af78
tree9b190cd503d2864830709948cf71ae0979115d3f
parent6d0c587048c85ca94723fc1bd900130cbe875eb3
USB: serial: omninet: fix reference leaks at open

commit 30572418b445d85fcfe6c8fe84c947d2606767d8 upstream.

This driver needlessly took another reference to the tty on open, a
reference which was then never released on close. This lead to not just
a leak of the tty, but also a driver reference leak that prevented the
driver from being unloaded after a port had once been opened.

Fixes: 4a90f09b20f4 ("tty: usb-serial krefs")
Signed-off-by: Johan Hovold <johan@kernel.org>
[bwh: Backported to 3.2:
 - The 'serial' variable is still needed for other initialisation
 - Adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/serial/omninet.c