powerpc/85xx: Add local_irq_restore in error handling code
authorJulia Lawall <julia@diku.dk>
Sun, 21 Dec 2008 20:54:45 +0000 (21:54 +0100)
committerKumar Gala <galak@kernel.crashing.org>
Tue, 30 Dec 2008 17:35:30 +0000 (11:35 -0600)
commit870029a682d468585a80ce782871f3f220cfef0f
treebd70e6d220408fc7e7480fa0b31a3d00992ee65f
parent8bd3947afda14625bff8c067b760840abfb51358
powerpc/85xx: Add local_irq_restore in error handling code

There is a call to local_irq_restore in the normal exit case, so it would
seem that there should be one on an error return as well.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression l;
expression E,E1,E2;
@@

local_irq_save(l);
... when != local_irq_restore(l)
    when != spin_unlock_irqrestore(E,l)
    when any
    when strict
(
if (...) { ... when != local_irq_restore(l)
               when != spin_unlock_irqrestore(E1,l)
+   local_irq_restore(l);
    return ...;
}
|
if (...)
+   {local_irq_restore(l);
    return ...;
+   }
|
spin_unlock_irqrestore(E2,l);
|
local_irq_restore(l);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
arch/powerpc/platforms/85xx/smp.c