random: Add comment to random_initialize()
authorTony Luck <tony.luck@intel.com>
Mon, 23 Jul 2012 16:47:57 +0000 (09:47 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 12 Sep 2012 02:37:30 +0000 (03:37 +0100)
commit86946487268d34e8c057e498ab01b03cc085874f
tree55194e49d8bac37b4a47625de0fe8b3e4dc01c5f
parent946887406e6d559a4a52fdbd836a85511b4f6486
random: Add comment to random_initialize()

commit cbc96b7594b5691d61eba2db8b2ea723645be9ca upstream.

Many platforms have per-machine instance data (serial numbers,
asset tags, etc.) squirreled away in areas that are accessed
during early system bringup. Mixing this data into the random
pools has a very high value in providing better random data,
so we should allow (and even encourage) architecture code to
call add_device_randomness() from the setup_arch() paths.

However, this limits our options for internal structure of
the random driver since random_initialize() is not called
until long after setup_arch().

Add a big fat comment to rand_initialize() spelling out
this requirement.

Suggested-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/char/random.c