md: always set MD_RECOVERY_INTR when aborting a reshape or other "resync".
authorNeilBrown <neilb@suse.de>
Wed, 28 May 2014 03:39:23 +0000 (13:39 +1000)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 11 Jul 2014 12:33:43 +0000 (13:33 +0100)
commit8197104d1f38f1826bb66e23eda1d06958129439
tree7ab34970ffdebe77e89b0791ea605da6366392f6
parent1e2f98c52b3b79761f9969ae6aef9c079192448b
md: always set MD_RECOVERY_INTR when aborting a reshape or other "resync".

commit 3991b31ea072b070081ca3bfa860a077eda67de5 upstream.

If mddev->ro is set, md_to_sync will (correctly) abort.
However in that case MD_RECOVERY_INTR isn't set.

If a RESHAPE had been requested, then ->finish_reshape() will be
called and it will think the reshape was successful even though
nothing happened.

Normally a resync will not be requested if ->ro is set, but if an
array is stopped while a reshape is on-going, then when the array is
started, the reshape will be restarted.  If the array is also set
read-only at this point, the reshape will instantly appear to success,
resulting in data corruption.

Consequently, this patch is suitable for any -stable kernel.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/md/md.c