usb: musb: Stop bulk endpoint while queue is rotated
authorAndrew Goodbody <andrew.goodbody@cambrionix.com>
Tue, 31 May 2016 15:05:27 +0000 (10:05 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 22 Aug 2016 21:37:13 +0000 (22:37 +0100)
commit7ba4a8aad2441531e9d434ef07312944c8cc91e4
treec4b5e6038ccd9726dc217afe8e8c511f0c4a701d
parent442f839f65a350dc3ee910fb83c30757566dc98b
usb: musb: Stop bulk endpoint while queue is rotated

commit 7b2c17f829545df27a910e8d82e133c21c9a8c9c upstream.

Ensure that the endpoint is stopped by clearing REQPKT before
clearing DATAERR_NAKTIMEOUT before rotating the queue on the
dedicated bulk endpoint.
This addresses an issue where a race could result in the endpoint
receiving data before it was reprogrammed resulting in a warning
about such data from musb_rx_reinit before it was thrown away.
The data thrown away was a valid packet that had been correctly
ACKed which meant the host and device got out of sync.

Signed-off-by: Andrew Goodbody <andrew.goodbody@cambrionix.com>
Signed-off-by: Bin Liu <b-liu@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[bwh: Backported to 3.2: adjust context, indentation]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/musb/musb_host.c