macvtap: limit head length of skb allocated
authorJason Wang <jasowang@redhat.com>
Wed, 13 Nov 2013 06:00:40 +0000 (14:00 +0800)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 9 May 2015 22:16:38 +0000 (23:16 +0100)
commit75f9b4534aa31e33e96ae36dd96a62907470da91
tree0b299331b8bdae6d2aa63db69878e292092e0ea5
parentd501ebeb7da7531e92e3c8d194730341c314ff2d
macvtap: limit head length of skb allocated

commit 16a3fa28630331e28208872fa5341ce210b901c7 upstream.

We currently use hdr_len as a hint of head length which is advertised by
guest. But when guest advertise a very big value, it can lead to an 64K+
allocating of kmalloc() which has a very high possibility of failure when host
memory is fragmented or under heavy stress. The huge hdr_len also reduce the
effect of zerocopy or even disable if a gso skb is linearized in guest.

To solves those issues, this patch introduces an upper limit (PAGE_SIZE) of the
head, which guarantees an order 0 allocation each time.

Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/macvtap.c