USB: serial: fix race in generic write
authorJohan Hovold <jhovold@gmail.com>
Sat, 9 Nov 2013 11:38:09 +0000 (12:38 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 3 Jan 2014 04:33:25 +0000 (04:33 +0000)
commit757bf43df88029f70acb519517234a8d0d83636c
tree0b8890627ea7fae0da752b5d0fcf86fdb2b49c2b
parentaea59757e00e792fae1f174742170564cdb2908b
USB: serial: fix race in generic write

commit 6f6485463aada1ec6a0f3db6a03eb8e393d6bb55 upstream.

Fix race in generic write implementation, which could lead to
temporarily degraded throughput.

The current generic write implementation introduced by commit
27c7acf22047 ("USB: serial: reimplement generic fifo-based writes") has
always had this bug, although it's fairly hard to trigger and the
consequences are not likely to be noticed.

Specifically, a write() on one CPU while the completion handler is
running on another could result in only one of the two write urbs being
utilised to empty the remainder of the write fifo (unless there is a
second write() that doesn't race during that time).

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[bwh: Backported to 3.2: deleted code is a bit different]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/serial/generic.c