drivers/net: remove duplicate structure field initialization
authorJulia Lawall <julia@diku.dk>
Sat, 19 Sep 2009 09:48:41 +0000 (09:48 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 22 Sep 2009 21:00:09 +0000 (14:00 -0700)
commit5ee2124524aa65cc48fcf0b498d4ef036d2c9ee5
tree3f993b2d0e1c79221695cf4e8ea3633442be329a
parent051b982bcc620695de629d29c333c95b66e9b95e
drivers/net: remove duplicate structure field initialization

The definitions of vnet_ops and ehea_netdev_ops have initializations of a
local function and eth_change_mtu for their respective ndo_change_mtu
fields.  This change uses only the local function.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier I, s, fld;
position p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@s@
identifier I, s, r.fld;
position r.p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@script:python@
p0 << r.p0;
fld << r.fld;
ps << s.p;
pr << r.p;
@@

if int(ps[0].line)!=int(pr[0].line) or int(ps[0].column)!=int(pr[0].column):
  cocci.print_main(fld,p0)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ehea/ehea_main.c
drivers/net/sunvnet.c