platform-drivers-x86: eeepc-laptop: fix wrong test for successful registered led_classdev
authorAxel Lin <axel.lin@gmail.com>
Mon, 8 Aug 2011 09:14:19 +0000 (17:14 +0800)
committerMatthew Garrett <mjg@redhat.com>
Mon, 24 Oct 2011 14:52:38 +0000 (16:52 +0200)
commit5d6afd150321a9e6f1180f5dced9032cce6861ac
tree83442856b52952204938be7873629ac79189a7d6
parent33989ba6f7feb3d03916e42d7775d802d2fdea1e
platform-drivers-x86: eeepc-laptop: fix wrong test for successful registered led_classdev

device_create returns &struct device pointer on success, or ERR_PTR() on error.
Thus if led_classdev_register fails, led_cdev->dev is always not NULL.

If IS_ERR(eeepc->tpd_led.dev) is ture, it means led_classdev_register fails.
If (asus->tpd_led.dev) is NULL, it means we call eeepc_led_exit before
calling led_classdev_register for &eeepc->tpd_led.

We only want to call led_classdev_unregister for sucessfully registered
led_classdev, then we should check (!IS_ERR_OR_NULL(eeepc->tpd_led.dev)).

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Corentin Chary <corentin.chary@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/eeepc-laptop.c