usbnet: don't clear urb->dev in tx_complete
authortom.leiming@gmail.com <tom.leiming@gmail.com>
Thu, 22 Mar 2012 03:22:38 +0000 (03:22 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Mar 2012 23:32:34 +0000 (19:32 -0400)
commit5d5440a835710d09f0ef18da5000541ec98b537a
tree3e6e9ed88b266beadbf9698c15852865acb2605a
parent0956a8c20b23d429e79ff86d4325583fc06f9eb4
usbnet: don't clear urb->dev in tx_complete

URB unlinking is always racing with its completion and tx_complete
may be called before or during running usb_unlink_urb, so tx_complete
must not clear urb->dev since it will be used in unlink path,
otherwise invalid memory accesses or usb device leak may be caused
inside usb_unlink_urb.

Cc: stable@kernel.org
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/usbnet.c