ALSA: ak411x: Fix stall in work callback
authorTakashi Iwai <tiwai@suse.de>
Tue, 13 Jan 2015 09:53:20 +0000 (10:53 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 6 Mar 2015 00:39:17 +0000 (00:39 +0000)
commit5c8edb8faee3068348fa040c22568f132e3643fa
treeb09b31a6ac23855af24cfdb9fd8d8b5e80d9438d
parentc024ef952a111ac8963bfc4edbec6e7a75fffd61
ALSA: ak411x: Fix stall in work callback

commit 4161b4505f1690358ac0a9ee59845a7887336b21 upstream.

When ak4114 work calls its callback and the callback invokes
ak4114_reinit(), it stalls due to flush_delayed_work().  For avoiding
this, control the reentrance by introducing a refcount.  Also
flush_delayed_work() is replaced with cancel_delayed_work_sync().

The exactly same bug is present in ak4113.c and fixed as well.

Reported-by: Pavel Hofman <pavel.hofman@ivitera.com>
Acked-by: Jaroslav Kysela <perex@perex.cz>
Tested-by: Pavel Hofman <pavel.hofman@ivitera.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
[bwh: Backported to 3.2: snd_ak411{3,4}_reinit were previously using
 flush_delayed_work_sync() rather than flush_delayed_work()]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
include/sound/ak4113.h
include/sound/ak4114.h
sound/i2c/other/ak4113.c
sound/i2c/other/ak4114.c