blktrace: fix accounting of partially completed requests
authorRoman Pen <r.peniaev@gmail.com>
Tue, 4 Mar 2014 14:13:10 +0000 (23:13 +0900)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 Apr 2014 15:23:20 +0000 (16:23 +0100)
commit5b85afa68e4f56c27f1d5c6f49e5257bce6448e6
tree2bcd93308d38d2fc1d5540abcdb99efe067792ff
parent631f96b5e27fdf9dc7b7e78201c01d05321f1494
blktrace: fix accounting of partially completed requests

commit af5040da01ef980670b3741b3e10733ee3e33566 upstream.

trace_block_rq_complete does not take into account that request can
be partially completed, so we can get the following incorrect output
of blkparser:

  C   R 232 + 240 [0]
  C   R 240 + 232 [0]
  C   R 248 + 224 [0]
  C   R 256 + 216 [0]

but should be:

  C   R 232 + 8 [0]
  C   R 240 + 8 [0]
  C   R 248 + 8 [0]
  C   R 256 + 8 [0]

Also, the whole output summary statistics of completed requests and
final throughput will be incorrect.

This patch takes into account real completion size of the request and
fixes wrong completion accounting.

Signed-off-by: Roman Pen <r.peniaev@gmail.com>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Ingo Molnar <mingo@redhat.com>
CC: linux-kernel@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@fb.com>
[bwh: Backported to 3.2: drop change in blk-mq.c]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
block/blk-core.c
include/trace/events/block.h
kernel/trace/blktrace.c