igb: Avoid uninitialized advertised variable in eee_set_cur
authorAndi Kleen <ak@linux.intel.com>
Mon, 30 Sep 2013 20:29:08 +0000 (13:29 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 2 Oct 2013 20:31:48 +0000 (16:31 -0400)
commit58e4e1f6cacddb7823c44bcfb272174553f6c645
treee049258977c26dabda0eb8824fa3f63788493968
parent52f77ba9256bc9dc0f7e6b37b03d00553e903d15
igb: Avoid uninitialized advertised variable in eee_set_cur

eee_get_cur assumes that the output data is already zeroed. It can
read-modify-write the advertised field:

              if (ipcnfg & E1000_IPCNFG_EEE_100M_AN)
2594 edata->advertised |= ADVERTISED_100baseT_Full;

This is ok for the normal ethtool eee_get call, which always
zeroes the input data before.

But eee_set_cur also calls eee_get_cur and it did not zero the input
field. Later on it then compares agsinst the field, which can contain partial
stack garbage.

Zero the input field in eee_set_cur() too.

Cc: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/intel/igb/igb_ethtool.c