kprobes/x86: Fix kprobes to skip prefixes correctly
authorMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Tue, 29 Jun 2010 05:53:50 +0000 (14:53 +0900)
committerIngo Molnar <mingo@elte.hu>
Tue, 29 Jun 2010 08:43:41 +0000 (10:43 +0200)
commit567a9fd86735ccdc897768ed2dacdd5e83a13509
tree2111af7e07f0d8d30c8aa72aa7b8ebe7555457fa
parenta1d0ce8213e9ddf4046ef5ba95c55762d075f541
kprobes/x86: Fix kprobes to skip prefixes correctly

Fix resume_execution() and is_IF_modifier() to skip x86
instruction prefixes correctly by using x86 instruction
attribute.

Without this fix, resume_execution() can't handle instructions
which have non-REX prefixes (REX prefixes are skipped). This
will cause unexpected kernel panic by hitting bad address when a
kprobe hits on two-byte ret (e.g. "repz ret" generated for
Athlon/K8 optimization), because it just checks "repz" and can't
recognize the "ret" instruction.

These prefixes can be found easily with x86 instruction
attribute. This patch introduces skip_prefixes() and uses it in
resume_execution() and is_IF_modifier() to skip prefixes.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
LKML-Reference: <4C298A6E.8070609@hitachi.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/kprobes.c