udp: fix behavior of wrong checksums
authorEric Dumazet <edumazet@google.com>
Sat, 30 May 2015 16:16:53 +0000 (09:16 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 6 Aug 2015 23:32:15 +0000 (00:32 +0100)
commit556574d97b6e0c2970b7e5ab693bcf35f73195fa
tree91922827c8006eebc9a478b7facbd8ab783cde5e
parent75cf667b7fac08a7b21694adca7dff07361be68a
udp: fix behavior of wrong checksums

commit beb39db59d14990e401e235faf66a6b9b31240b0 upstream.

We have two problems in UDP stack related to bogus checksums :

1) We return -EAGAIN to application even if receive queue is not empty.
   This breaks applications using edge trigger epoll()

2) Under UDP flood, we can loop forever without yielding to other
   processes, potentially hanging the host, especially on non SMP.

This patch is an attempt to make things better.

We might in the future add extra support for rt applications
wanting to better control time spent doing a recv() in a hostile
environment. For example we could validate checksums before queuing
packets in socket receive queue.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/ipv4/udp.c
net/ipv6/udp.c