HID: roccat: prevent an out of bounds read in kovaplus_profile_activated()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 10 Jan 2018 09:39:03 +0000 (12:39 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 31 May 2018 23:30:10 +0000 (00:30 +0100)
commit50a44c165a67ff0b7e14d221af6cb6c1035aa90a
tree5b0703e86031e777efb0885151139876f774ced2
parentf064e3c7e09390ea48a5fbda0528e145fba432b5
HID: roccat: prevent an out of bounds read in kovaplus_profile_activated()

commit 7ad81482cad67cbe1ec808490d1ddfc420c42008 upstream.

We get the "new_profile_index" value from the mouse device when we're
handling raw events.  Smatch taints it as untrusted data and complains
that we need a bounds check.  This seems like a reasonable warning
otherwise there is a small read beyond the end of the array.

Fixes: 0e70f97f257e ("HID: roccat: Add support for Kova[+] mouse")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Silvan Jegen <s.jegen@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/hid/hid-roccat-kovaplus.c