ext4: fix ext4_discard_allocated_blocks() if we can't allocate the pa struct
authorTheodore Ts'o <tytso@mit.edu>
Thu, 31 Jul 2014 02:17:17 +0000 (22:17 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 13 Sep 2014 22:41:41 +0000 (23:41 +0100)
commit5024a6ef2ed20ef5553288ca6abb9cb10126c632
tree51a3d7628f71dea7b6408f61188bde810e1af00e
parent6f98bebd1045df37a8c7ab1c43b82a0937c2e87f
ext4: fix ext4_discard_allocated_blocks() if we can't allocate the pa struct

commit 86f0afd463215fc3e58020493482faa4ac3a4d69 upstream.

If there is a failure while allocating the preallocation structure, a
number of blocks can end up getting marked in the in-memory buddy
bitmap, and then not getting released.  This can result in the
following corruption getting reported by the kernel:

EXT4-fs error (device sda3): ext4_mb_generate_buddy:758: group 1126,
12793 clusters in bitmap, 12729 in gd

In that case, we need to release the blocks using mb_free_blocks().

Tested: fs smoke test; also demonstrated that with injected errors,
the file system is no longer getting corrupted

Google-Bug-Id: 16657874

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/ext4/mballoc.c