USB: EHCI: fix NULL pointer dererence in HCDs that use HCD_LOCAL_MEM
authorAndrea Righi <arighi@develer.com>
Mon, 28 Jun 2010 14:56:45 +0000 (16:56 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 10 Aug 2010 21:35:38 +0000 (14:35 -0700)
commit4307a28eb0128417d9a2b9d858d2bce70ee5b383
tree46efab423c646ba4a994533b1e5befe523fbf08a
parente10fa4787f1fb9c8738dff955c272f30b7b63134
USB: EHCI: fix NULL pointer dererence in HCDs that use HCD_LOCAL_MEM

If we use the HCD_LOCAL_MEM flag and dma_declare_coherent_memory() to
enforce the host controller's local memory utilization we also need to
disable native scatter-gather support, otherwise hcd_alloc_coherent() in
map_urb_for_dma() is called with urb->transfer_buffer == NULL, that
triggers a NULL pointer dereference.

We can also consider to add a WARN_ON() and return an error code to
better catch this problem in the future.

At the moment no driver seems to hit this bug, so I should
consider this a low-priority fix.

Signed-off-by: Andrea Righi <arighi@develer.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/core/hcd.c
drivers/usb/host/ehci-hcd.c