drivers/isdn: Drop unnecessary NULL test
authorJulia Lawall <julia@diku.dk>
Sun, 12 Jul 2009 20:05:03 +0000 (22:05 +0200)
committerKarsten Keil <keil@b1-systems.de>
Sat, 25 Jul 2009 18:22:51 +0000 (20:22 +0200)
commit3cad3da3ed9ece03704f7d67e038b8ae710fa312
treedc20a8b7272d027b889a8c3df6ca0963ded3d018
parenta900845e56617edc005fd8f35bfd5a407aaf96c8
drivers/isdn: Drop unnecessary NULL test

The result of container_of should not be NULL.  In particular, in this case
the argument to the enclosing function has passed though INIT_WORK, which
dereferences it, implying that its container cannot be NULL.

A simplified version of the semantic patch that makes this change is as
follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
identifier fn,work,x,fld;
type T;
expression E1,E2;
statement S;
@@

static fn(struct work_struct *work) {
  ... when != work = E1
  x = container_of(work,T,fld)
  ... when != x = E2
- if (x == NULL) S
  ...
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Karsten Keil <keil@b1-systems.de>
drivers/isdn/hisax/amd7930_fn.c
drivers/isdn/hisax/hfc_pci.c
drivers/isdn/hisax/hfc_sx.c
drivers/isdn/hisax/icc.c
drivers/isdn/hisax/isac.c
drivers/isdn/hisax/w6692.c