mfd: Don't use mutex_lock_interruptible in ab8500-core
authorRabin Vincent <rabin.vincent@stericsson.com>
Thu, 8 Mar 2012 13:01:46 +0000 (14:01 +0100)
committerSamuel Ortiz <sameo@linux.intel.com>
Fri, 16 Mar 2012 18:43:36 +0000 (19:43 +0100)
commit392cbd1e608ba79bd2da652eb3a28d841e51eaee
tree2c6b20c16188fd1b4ecf25ebf7df02b2c61ed488
parentbd155d2c3c8b04d66f7890dbd9539c37e9dea02b
mfd: Don't use mutex_lock_interruptible in ab8500-core

This disadvantage of having it interruptible is that it would
appear to work OK in most situations, but in the rare case
that this call does fail, it can lead to misconfiguration
of the AB, such as a regulator not being turned off and
leading to a platform power consumption increase.

There's no real benefit to having this interruptible.

Make it a plain mutex_lock. The non-interruptability matches
other low-level I/O functions such as SPI and I2C.

Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/ab8500-core.c