atp: remove set_rx_mode_8012()
authorPaul Bolle <pebolle@tiscali.nl>
Fri, 2 Nov 2012 23:53:15 +0000 (23:53 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 19 Mar 2018 18:58:25 +0000 (18:58 +0000)
commit3624d8a5693c7664906d40ffac19e1ec786a702d
treecc2180836f33ec48501a13ec6353624b3a5d771c
parent13ee32de97e76498fad43c6f424bb6c3025537dc
atp: remove set_rx_mode_8012()

commit bb263e18f481199a04f7aab9454c18cd3dbdb218 upstream.

Building atp.o triggers this GCC warning:
    drivers/net/ethernet/realtek/atp.c: In function ‘set_rx_mode’:
    drivers/net/ethernet/realtek/atp.c:871:26: warning: ‘mc_filter[0]’ may be used uninitialized in this function [-Wuninitialized]

GCC is correct. In promiscuous mode 'mc_filter' will be used
uninitialized in set_rx_mode_8012(), which is apparently inlined into
set_rx_mode().

But it turns out set_rx_mode_8012() will never be called, since
net_local.chip_type will always be RTL8002. So we can just remove
set_rx_mode_8012() and do some related cleanups.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/ethernet/realtek/atp.c
drivers/net/ethernet/realtek/atp.h